-
Notifications
You must be signed in to change notification settings - Fork 908
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor rewrite_array, pair, tuple, call #6248
Conversation
@ding-young When I took a quick look at the code I was surprised to see If it's not possible, or just too much effort to add the |
138f4d4
to
8339bbd
Compare
I removed |
8339bbd
to
f679a4e
Compare
f679a4e
to
4caeb34
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I kicked off the Diff-Check job. Assuming it passes I think we're good to go on this one.
Edit: The job passed ✅
Tracked by #6206
Description
:
rewrite_array
,rewrite_pair
,rewrite_tuple
,rewrite_call
and
rewrite_with_***
insrc/overflow.rs
ast::MetaItem
insrc/attrs.rs
Question & TODO
I used
DUMMY_SP
for generating dummy span ofmax_width_error
inrewrite_pair
,rewrite_all_pairs
and its callees. There might be a better way to manually create an appropriate span for PairPart, and I need to give it more thought.